Remove PHP and Ruby implementations and related files #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit deletes all PHP and Ruby source code, documentation, instructions, CI workflows, and code metrics from the repository. References to PHP and Ruby have been removed from documentation, comparison tables, inventory, and workflow files to reflect that only six language implementations remain (TypeScript, Python, Java, C#, Go, Kotlin).
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes the PHP and Ruby language implementations from the lamp-control-api-reference repository. The changes include deletion of all source code, tests, documentation, ADRs (Architecture Decision Records), CI workflows, configuration files, and code coverage reports for both PHP and Ruby implementations, reducing the project from 8 to 6 language implementations.
Changes:
- Complete removal of PHP implementation including source code, tests, configuration, and coverage reports
- Complete removal of Ruby implementation including source code, tests, and Architecture Decision Records
- Deletion of all supporting files (nginx configs, composer files, bundler configs, etc.)
Reviewed changes
Copilot reviewed 97 out of 125 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/ruby/adr/*.md | Deleted Ruby Architecture Decision Records for bundler dependency management, framework selection, and version choice |
| src/ruby/README.md | Deleted Ruby implementation README |
| src/php/lamp-control-api/tests/**/* | Deleted all PHP test files including unit tests, E2E tests, and test bootstrap |
| src/php/lamp-control-api/lib/**/* | Deleted PHP source code including API implementations, models, entities, mappers, services, and repositories |
| src/php/lamp-control-api/public/* | Deleted PHP public directory files including index.php and .htaccess |
| src/php/lamp-control-api/coverage/**/* | Deleted PHP code coverage HTML reports, CSS, JavaScript, and assets |
| src/php/lamp-control-api/*.php | Deleted PHP configuration files (router.php) |
| src/php/lamp-control-api/*.xml | Deleted PHPUnit configuration files |
| src/php/lamp-control-api/*.neon.dist | Deleted PHPStan configuration |
| src/php/lamp-control-api/project.toml | Deleted project deployment configuration |
| src/php/lamp-control-api/scripts/*.sh | Deleted coverage checking scripts |
| src/php/lamp-control-api/logs/.htaccess | Deleted logs directory configuration |
| src/php/lamp-control-api/nginx.conf | Deleted nginx configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updated InMemoryLampRepository to retain the original createdAt timestamp when updating an existing LampEntity, ensuring createdAt is not overwritten during updates. Also added more bash commands to the Claude settings allowlist.
This reverts commit 2b08835.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit deletes all PHP and Ruby source code, documentation, instructions, CI workflows, and code metrics from the repository. References to PHP and Ruby have been removed from documentation, comparison tables, inventory, and workflow files to reflect that only six language implementations remain (TypeScript, Python, Java, C#, Go, Kotlin).